I've had several users complain that when they add new stories since I applied your hotfix, that the Characters, Genres, nor Warnings are showing up, even though they've been selected. I've tested this myself and the behavior has been confirmed. Please see our Most Recent to see a definite shift in behavior:
http://adastrafanfic.com/browse.php?type=recent
I'd rather keep the hotfix in, especially since it has a big effect on our security, so I haven't backed it out entirely (just the config.php portion). If this isn't going to be fixed in 3.5.3, please let me know.
Thanks,
-- jb
Archive: Ad Astra Star Trek Fanfiction Archive
Version: 3.5.3
Skin: One of Kali's, but I'm not sure. It's been heavily modded.
PHP: 7.4.27
MySQL: 5.7.36
Well, since the entire hotfix path was way off the optimal, just to make sure, that you have only the changes to the viewseries.php and both the mysql files in place?
So neither config.php nor dbfunctions.php should have modifications.
I attached working files to the post in the vulnerability topic.
I did, yeah. Actually, let me double-check the dbfunctions.php... I may not have backed those out.
-- jb
UPDATE: No, dbfunctions.php was backed out as well. I'm showing the original (compared against a fresh download of 3.5.3) file.
Archive: Ad Astra Star Trek Fanfiction Archive
Version: 3.5.3
Skin: One of Kali's, but I'm not sure. It's been heavily modded.
PHP: 7.4.27
MySQL: 5.7.36
Well, then the error is technically impossible, since I rolled back so far, all that's left is a change to viewseries.php
The changes to the mysql functions are half cosmetic, half making them array-safe, but they will not do anything else than before.
config.php sure has no further functions other than calling dbfunctions.php?
I'm having the same problems on my site a well. Was a solution found yet?
I'm having the same problems on my site a well. Was a solution found yet?
I had this problem with the first hotfix came out, but when changes were made (to the current hotfix) I uploaded my original unedited files and started again. Since I did that, I no longer had the error.
Can you confirm what files you have changed?
eFiction Archives:
I backed out the fix and only uploaded the viewseries.php and the two MySQL files and it fixed the problem. Thanks for the quick response.
I backed out the fix and only uploaded the viewseries.php and the two MySQL files and it fixed the problem. Thanks for the quick response.
Glad to hear it!
jetblack, would you be able to post the contents of your config.php and dbfunctions.php files (with the database information *** out)?
eFiction Archives:
Sorry for the delay, Banshee. I'm traveling in the UK and have been out of touch. Let me grab those two file for you.
-- jb
Archive: Ad Astra Star Trek Fanfiction Archive
Version: 3.5.3
Skin: One of Kali's, but I'm not sure. It's been heavily modded.
PHP: 7.4.27
MySQL: 5.7.36
dbfunctions.php:
<?php
if(function_exists("mysqli_connect")) include_once(_BASEDIR."includes/mysqli_functions.php");
else if(function_exists("mysql_connect")) include_once(_BASEDIR."includes/mysql_functions.php");
else {
include(_BASEDIR."languages/en.php"); // Because we haven't selected a language setting yet
die(_FATALERROR._NODBFUNCTIONALITY);
}
-- jb
Archive: Ad Astra Star Trek Fanfiction Archive
Version: 3.5.3
Skin: One of Kali's, but I'm not sure. It's been heavily modded.
PHP: 7.4.27
MySQL: 5.7.36
config.php:
<?php
$dbhost = "XXXXX";
$dbname = "XXXXX";
$dbuser= "XXXXX";
$dbpass = "XXXXX";
$sitekey = "XXXXX";
$settingsprefix = "";
include_once("includes/dbfunctions.php");
if(!empty($sitekey)) $dbconnect = dbconnect($dbhost, $dbuser,$dbpass, $dbname);
$_GET = array_map('stripslashes', $_GET);
$_POST = array_map('stripslashes', $_POST);
// if($dbconnect)
//{
// $_GET = escapestring($_GET);
// $_POST = escapestring($_POST);
//}
//
?>
-- jb
Archive: Ad Astra Star Trek Fanfiction Archive
Version: 3.5.3
Skin: One of Kali's, but I'm not sure. It's been heavily modded.
PHP: 7.4.27
MySQL: 5.7.36
Hi jetblack - thanks for that.
You'll want to remove the changes that were made to the config file, so it should only look like the below:
<?php
$dbhost = "XXXXX";
$dbname = "XXXXX";
$dbuser= "XXXXX";
$dbpass = "XXXXX";
$sitekey = "XXXXX";
$settingsprefix = "";
include_once("includes/dbfunctions.php");
if(!empty($sitekey)) $dbconnect = dbconnect($dbhost, $dbuser,$dbpass, $dbname);
?>
If you haven't done so already, go to this post and make the changes listed there to the includes/mysqli_functions.php, includes/mysql_functions.php and viewseries.php files.
The original change that you made was replaced a couple of hours later, since people were experiencing the posting problems you're encountering.
eFiction Archives:
Banshee:
Looks like the config file was the only one out of sorts. I had already made the changes to the other files. Seems like it's back to previous functionality.
Thank you very much!
-- jb
Archive: Ad Astra Star Trek Fanfiction Archive
Version: 3.5.3
Skin: One of Kali's, but I'm not sure. It's been heavily modded.
PHP: 7.4.27
MySQL: 5.7.36
