[CLOSED] Version Check Screws up site

Tammy will no doubt correct me, but you could log in, go to Admin->Panels. Look for Version Check in that list and click edit  from there I think clicking on the 'hidden' check box (then submit)  might stop it from appearing on your menu of choices when in Admin. (Mind you there's a delete but I don't know that deleting it would be a good thing).

I got that error on mine. It didn't cause any harm that I know of to the site. It just kept going till I stopped it. Is there a way to avoid this? Other than just not clicking it?

Saturn, like I said above, I've fixed this, and as soon as it's tested, I'll let Tammy know so she can include it in the download. (I originally wrote the code for this, but I adapted what someone else had done for 2.0 in a mod so, while I can't take that much credit for creating it, I did try to fix it.) Go ahead and do what Babaca said if you're concerned.

For anyone who might want to try the new file, replace your admin>versioncheck.php file with the following:

<?php

if(!defined("_CHARSET")) exit( );

$output .= "<div id="pagetitle">"._VERSIONCHECK."</div>";

// make sure curl is installed
if (function_exists('curl_init')) {
$output .= write_message(_RUNNINGVERSION);
   // initialize a new curl resource
   $ch = curl_init();

   // set the url to fetch
   curl_setopt($ch, CURLOPT_URL, ' https://efiction.org/version.txt'); 

   // don't give me the headers just the content
   curl_setopt($ch, CURLOPT_HEADER, 0);

   // return the value instead of printing the response to browser
   curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);

   // use a user agent to mimic a browser
   curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0');

   $content = curl_exec($ch);
   $currentversion = $content;
$output .= write_message(_CURRENTVERSION. "$currentversion");

if ($currentversion != $version) {
$output .= write_message (_UPDATEVERSION);
}
else $output .= write_message (_UPTODATE);

   // remember to always close the session and free all resources
   curl_close($ch);
}

else if(ini_get("allow_url_fopen")) {
$output .= write_message(_RUNNINGVERSION);

$location = fopen (" https://efiction.org/version.txt",  "r");
$buffer = '';
while (!feof ($location)) {
$buffer .= fgets($location, 4096);
}
fclose ($location);

if ($buffer != '') {
$currentversion = $buffer;
$output .= write_message(_CURRENTVERSION. "$currentversion");

if ($currentversion != $version) {
$output .= write_message (_UPDATEVERSION);
}
else $output .= write_message (_UPTODATE);
}
}
else {
$output .= write_message(_VERSIONNOTALLOWED);
}

?>

Please let me know if you get any errors (besides a missing definition if you server doesn't allow either fopen or curl). If you were having problems before, please let me know if it's solved them. What the file does is try to run the check using curl, if that doesn't work, try with fopen, and if that doesn't work, print a message saying it won't work. This should, in theory, stop the infinite loops. I can't test that because my server has both curl and fopen on and I never got any error messages.

All appears to be working and fine with the fix you provided Carissa. Thanks 🙂

EDIT: I'm not sure if this is due to the fix, or is simply just this way, but it's displaying:

You are currently running eFiction version 3.1.
The current version of eFiction is 3.1.1

Even though I do have 3.1.1, is it possible Tammy this was not changed in the update?

It wasn't changed in the update. I think it's discussed elsewhere.

Works great, thanks.

Version Check
You are currently running eFiction version 3.1.1.
The current version of eFiction is 3.1.1
You are up to date.