Original thread: https://efiction.org/community/3-x-solved-bugs/search-php-advanced-search-alphabetical-most-recent-sorting-issue-solved/
Found the actual issue after looking at the original cleaned-up patch and a pre-patched search.php on an old eFiction 3.x install; it dawned on me: the name for the select drop-down menu code is wrong: it's 'sort' rather than 'sortorder'. The id is correct, however.
Can't reply to solved threads, so a new one exists.
Segment (Line 323 in eFiction 3.5.84b):
<label for=\"sortorder\">"._SORT.":</label> <select name=\"sortorder\" id=\"sortorder\"><option value=\"alpha\">"._ALPHA."</option><option value=\"update\">"._MOSTRECENT."</option></select>";
Replace With:
<label for=\"sortorder\">"._SORT.":</label> <select name=\"sort\" id=\"sortorder\"><option value=\"alpha\">"._ALPHA."</option><option value=\"update\">"._MOSTRECENT."</option></select>";
This is the definitive fix, for sure. 🙂
Site: http://cwcyrix.nsupdate.info/fhaven/ (private, archived)
Version: eFiction 3.5.3
Modules: Challenges 1.4, Recs 1.4.2
PHP: 5.6.40, self-patched
Other Setups (same server):
Test Site 1: http://cwcyrix.nsupdate.info/ef-testing-grounds/ (eFiction 3 Mod - chaotic, PHP 8.6.0RC4)
Test Site 2: http://cwcyrix.nsupdate.info/eee/ (eFiction 3 Mod - stable, PHP 8.5.12)
Test Site 3: http://cwcyrix.nsupdate.info/ef-clean/ (patched 'future' eFiction 3.5.9, self-patched PHP 7.4.33)
Rest of Server Details
OS - Distro: Ubuntu Linux Server 26.04 LTS (home)
Web Server: Apache httpd 2.4.69
MariaDB: 11.4.13