3.5: minmimizing categories makes them vanish in admin panel [fixed in 352]

Whoa, my site's doing that too.  (3.4.3)  Also, a video?  Sweet.

I don't have that problem but it's probably because I don't have sub-categories. But I concur with Lyndsie video evidence is sweet. 😉

Yeah, the free trial ran out so i'll figure something out if i see anything else.

At any rate, I compared the category.php files under admin across updates. Not sure what  it is I'm looking for.

http://fanforge.net (this works) 3.4.2

      http://pastebin.com/m61920499

        if (isset($_POST["submit"]) && !isset($_GET['catcounts'])) {
                if(isset($_POST['catid']) && $_POST['parentcatid'] == $_POST['catid']) {
                        $output .= write_error(_ACTIONCANCELLED." "._CATERROR);
                        $tpl->assign( "output", $output );
                        $tpl->printToScreen();
                        dbclose( );
                        exit( );

http://beta.fanforge.net (does not work) 3.5

      http://pastebin.com/m6c2fbda1

        if (isset($_POST["submit"]) && !isset($_GET['catcounts'])) {
                if(isset($_POST['catid']) && $_POST['parentcatid'] == $_POST['catid']) $output .= write_error(_ACTIONCANCELLED." "._CATERROR);

It appears a section was cut out, thoughts? I reverted it, its broke on my test site still. I'll see if there is another associated section. That's the only difference between the files, thi sis weird. would there be something in includes?

Maybe it's the AJAX? I don't have subcategories, so I'm not sure.

Alright, next up

i don't have a 3.4.2 fresh build handy, i looked in y backups and found a 3.4 build so eh if you have a 3.4.2 build, please pass me the categories list includes file

3.4

$cats = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_categories WHERE parentcatid = '$catid'");

3.5

$cats = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_categories WHERE parentcatid = '$catid' OR catid = '$catid' ORDER BY leveldown, displayorder");

Curious how there is more code in the latter one. I'd like to know what this code does.

includes/categorylist.php from 3.4.2:

<?php
define("_BASEDIR", "../");
include("../config.php");
include("../includes/dbfunctions.php");
list($tableprefix) = dbrow(dbquery("SELECT tableprefix FROM ".$settingsprefix."fanfiction_settings WHERE sitekey = '$sitekey'"));
define("TABLEPREFIX", $tableprefix);
include("../includes/queries.php");

$catid = isset($_GET['catid']) && preg_match("/^[0-9]+$/", $_GET['catid']) ? $_GET['catid'] : -1;
$cats = dbquery("SELECT * FROM ".TABLEPREFIX."fanfiction_categories WHERE parentcatid = '$catid'");
echo "var el = '".$_GET['element']."';n";
$x = 0;
$find = array ('"', chr(150), chr(147), chr(148), chr(146));
$replace = array ('"', "-", """, """, "'");
while($category = dbassoc($cats)) {
echo "categories[$x] = new category(".$category['parentcatid'].", ".$category['catid'].", "".htmlentities(str_replace($find, $replace, stripslashes($category['category'])))."", ".$category['locked'].", ".$category['displayorder'].");rn";
$x++;
}
?>

The difference you're noting first appears in 3.4.3.

and i presume that build works ok.

I have no idea.  I don't currently have it installed anywhere.  I just have copies of pretty much every 3.x version of eFiction.  If you want any of the zips, let me know.

hmm alright, itanshi - gmail

send me eh, i have 3.4 and 3.5 so the versions between, thanks so much ^^

I compared files, i dunno what the problem is. This problem is pretty urgent. I can't feasibly manage categories from the website with this error.

Please check and see if this is an issue still with 3.5.1. Thank you.

Yeah, it was patched in the svn. I don't think it is in the zip tho

What does svn mean?

http://efiction.svn.sourceforge.net/

check the news update