Notifications
Clear all

[3.5] Category links go to the category main page and not the story list

9 Posts
4 Users
0 Reactions
3,769 Views
(@jadedsabre)
Posts: 10
Active Member
Topic starter
 

URL to your eFiction: http://archive.starwarschicks.com
Version of eFiction: 3.5
Have you bridged eFiction, if so with what?: No
Version of PHP: 5.2.5
Version of MySQL: 4.1.22
Have you searched for your problem: Yes, this has been an issue for a very long time!
If so, what terms did you try: category link
State the nature of your problem:

Both the Categories Panel links and the Category: link in the Story listing point to

 http://archive.starwarschicks.com/browse.php?type=categories&catid=1 

which takes you to the category main page, because the actual story listing by category is
http://archive.starwarschicks.com/browse.php?type=categories&id=1

This has been an issue for some time.  See the following threads:
https://efiction.org/forums/index.php?topic=6347.0         Category links on index are going directly to category main page. 
https://efiction.org/forums/index.php?topic=6621.0         Category links on index are going directly to category main page. (Same topic, different thread) 
https://efiction.org/forums/index.php?topic=6192.0         3.4.2 bug: Link goes to the wrong page.   

[Solution]
According to Tammy in this thread:  https://efiction.org/forums/index.php?topic=6192.0

The id link is correct.  So the question is what took you to the catid link?

Using that note, I changed the links to point to "id" rather than "catid", which solves the problem.  You need to edit the following:

/blocks/categories/categories.php line 44
/blocks/categories/categories.php line 67
/browse/categories.php line 57
/includes/corefunctions.php line 495

In each, change

browse.php?type=categories&catid=

to

browse.php?type=categories&id=


 
Posted : 04/02/2009 7:49 pm
(@lyndsie)
Posts: 1263
Member Moderator
 

You should take the BBC code out of the stuff in the code tags so it doesn't confuse the newbies. : )

Incidentally, I don't have this problem at all on my test site, which is at 3.5.

http://efictiontest.verilyviridian.com/browse.php?type=categories&catid=1

If I change the URL to id=1, it's the same as http://efictiontest.verilyviridian.com/browse.php?type=categories.

Did you try itanshi's fix in that one thread you linked? It seems easier.


 
Posted : 05/02/2009 12:06 pm
(@jadedsabre)
Posts: 10
Active Member
Topic starter
 

You should take the BBC code out of the stuff in the code tags so it doesn't confuse the newbies. : )

Whoops, didn't catch that.  Fixed now.  Thanks.

That's odd.  I wonder if yours works because you only have 1 category.  Everyone I've seen that's having the issue has more than one category.  Whatever the reason, something funky is going on.  πŸ˜•


 
Posted : 05/02/2009 12:22 pm
(@lyndsie)
Posts: 1263
Member Moderator
 

LOL, just edited my post.  This is what I said:
Did you try itanshi's fix in that one thread you linked? It seems easier.  That's the one where you say Tammy provides a fix, down at the bottom.

Yeah, I just added another category, and nothing changed.  And the live site, at 3.4.3 (which should be affected, since it goes back aways) isn't affected either.

What modules and blocks do you have installed/initialized?


 
Posted : 05/02/2009 12:25 pm
(@jadedsabre)
Posts: 10
Active Member
Topic starter
 

Yes, I did try the fix suggested by itanshi in the 3rd thread.  It did not fix the issue, which I found odd.  It didn't break it either, which I found even odder.

That's why I went the other way and changed the links to match, because I couldn't get the story list by category link to change to "catid".

Blocks I'm using:  skinchange, search, random, categories, login, news, recent, info, featured, menu.

I do not have any modules installed.


 
Posted : 05/02/2009 12:30 pm
(@lyndsie)
Posts: 1263
Member Moderator
 

So that's just the basic ones, then.  That's really odd.  Unless maybe one of the modules I've got actually fixes the issue.

Or possibly it might have to do with PHP 5?  I have 4 on both my servers.


 
Posted : 05/02/2009 12:59 pm
(@itanshi)
Posts: 381
Reputable Member
 

you know what's weird? The fix is still applied to my old install and I could not reproduce the problem.

I installed the new 3.5 on another server, quite fresh. I was unable to reproduce the problem.

The code where ID was changed to CatID as mentioned in my initial bug report for 3.4.2 is exactly the same from my modification to the updated 3.5 code. I suspect this is why I am unable to reproduce problems in either install.


I am rebuilding efiction! Join us on irc! #efiction at www.mibbit.com Instructions for irc πŸ˜€ Alpha released!

 
Posted : 08/02/2009 9:12 pm
(@itanshi)
Posts: 381
Reputable Member
 

Maybe I was testing wrong before, but this is so still a problem.

http://fanforge.net/browse.php?type=categories&catid=187

Click the category title and yeah wrong location.


I am rebuilding efiction! Join us on irc! #efiction at www.mibbit.com Instructions for irc πŸ˜€ Alpha released!

 
Posted : 21/04/2009 3:35 pm
(@tammy)
Posts: 2577
Member Moderator
 

Seems to be working now in 3.5.1.


 
Posted : 23/06/2009 12:01 am
Share: