Notifications
Clear all

{SOLVED} Can't respnd to reviews

40 Posts
16 Users
0 Reactions
8,558 Views
(@aithine)
Posts: 10
Active Member
 

Fix (instead of Livia's workaround):

user/revres.php, line 30:

$result = dbquery("SELECT review, reviewid, item, type, chapid, uid 
FROM ".$tableprefix."fanfiction_reviews
WHERE reviewid = '".$_POST['rid']."' LIMIT 1");

Should actually read:

$result = dbquery("SELECT review, reviewid, item, type, r.chapid, c.uid 
FROM ".$tableprefix."fanfiction_reviews AS r
LEFT JOIN ".$tableprefix."fanfiction_chapters AS c ON c.chapid = r.chapid
WHERE reviewid = '".$_POST['rid']."' LIMIT 1");

No other changes to the code need to be made.

This correctly assigns $uid on line 32 to the author of the chapter, rather than the author of the review.


 
Posted : 04/05/2007 1:38 pm
(@tammy)
Posts: 2577
Member Moderator
 

Except the $uid from the query on line 30 is supposed to be the uid of the reviewer.  It's used to send the e-mail to the reviewer that the author responded.


 
Posted : 05/05/2007 11:48 pm
(@aithine)
Posts: 10
Active Member
 

Hmm, right. Ok, minor adjustments to lines 30-33:

		$result = dbquery("SELECT review, reviewid, item, type, r.chapid, c.uid, r.uid FROM ".$tableprefix."fanfiction_reviews AS r LEFT JOIN ".$tableprefix."fanfiction_chapters AS c ON c.chapid = r.chapid WHERE reviewid = '".$_POST['rid']."' LIMIT 1");
list($review, $reviewid, $item, $type, $chapid, $authid, $uid) = dbrow($result);
if($adminloggedin || $authid == $useruid) {

 
Posted : 06/05/2007 12:24 am
(@tammy)
Posts: 2577
Member Moderator
 

The simple solution is to just take that if statement out.  Remove line 32 and line 44.


 
Posted : 06/05/2007 1:52 am
Jan_AQ
(@jan_aq)
Posts: 1300
Noble Member
 

Review response will work in 3.3. πŸ™‚


Whoever said nothing is impossible never tried slamming a revolving door.

url: https://www.potionsandsnitches.org/fanfiction
php: 7.4.33 msql: 5.6.51-community GPL
efic version: 3.5.5 latest patches: yes
bridges: none mods: challenges, tracker, story end, beta, word

 
Posted : 18/05/2007 3:28 am
 tptb
(@tptb)
Posts: 19
Active Member
 

Do we have a projected date for 3.3 ?....

Thanks
TPTB


 
Posted : 22/05/2007 9:11 am
Jan_AQ
(@jan_aq)
Posts: 1300
Noble Member
 

Nope, sorry. πŸ™‚ Still working the bugs out.


Whoever said nothing is impossible never tried slamming a revolving door.

url: https://www.potionsandsnitches.org/fanfiction
php: 7.4.33 msql: 5.6.51-community GPL
efic version: 3.5.5 latest patches: yes
bridges: none mods: challenges, tracker, story end, beta, word

 
Posted : 23/05/2007 1:12 am
(@britannia)
Posts: 10
Active Member
 

I could never get my site reviews to work properly (uses latest version) so I used steve34's mod and it works great, the members love it.

https://efiction.org/forums/index.php?topic=4956.0

If you want to see what it looks like I have it set up on my test site (yes I know it says 1.1, but I promise that it's the lastest version, I just never changed the file name)

https://efiction.org/forums/index.php?topic=4956.0

http://www.blacksole.co.uk/e-fiction/e-fiction1.1/index.php

There are stories and reviews posted for this test member that your welcome to look at:

Brit4

password = crones


 
Posted : 05/06/2007 6:51 pm
(@jacci)
Posts: 503
Honorable Member
Topic starter
 

Update on this:
just installed 3.3 on my test site 
http://www.pretendercentre.com/missingtest/index.php
and tried to respond to reviews if it is a co-author on both admin  and member unless i am primary author  and got this message

You are not authorized to access that function.

the single author stories seem to be fine

ETA: might start a new thread for this since it is sort of a separate issue.


why is nothing ever easy?
url: http://www.pretendercentre.com/missingpieces/     
php: 5.2.5  msql: 5.0.45-community
efic version: 3.4.3           latest patches: yes
bridges: none              mods: challenges, displayword, beta-search

 
Posted : 08/06/2007 6:42 am
(@jacci)
Posts: 503
Honorable Member
Topic starter
 

Marking this as solved for 3.3


why is nothing ever easy?
url: http://www.pretendercentre.com/missingpieces/     
php: 5.2.5  msql: 5.0.45-community
efic version: 3.4.3           latest patches: yes
bridges: none              mods: challenges, displayword, beta-search

 
Posted : 16/06/2007 8:21 pm
Page 3 / 3
Share: