Fix (instead of Livia's workaround):
user/revres.php, line 30:
$result = dbquery("SELECT review, reviewid, item, type, chapid, uid
FROM ".$tableprefix."fanfiction_reviews
WHERE reviewid = '".$_POST['rid']."' LIMIT 1");
Should actually read:
$result = dbquery("SELECT review, reviewid, item, type, r.chapid, c.uid
FROM ".$tableprefix."fanfiction_reviews AS r
LEFT JOIN ".$tableprefix."fanfiction_chapters AS c ON c.chapid = r.chapid
WHERE reviewid = '".$_POST['rid']."' LIMIT 1");
No other changes to the code need to be made.
This correctly assigns $uid on line 32 to the author of the chapter, rather than the author of the review.
Except the $uid from the query on line 30 is supposed to be the uid of the reviewer. It's used to send the e-mail to the reviewer that the author responded.
Hmm, right. Ok, minor adjustments to lines 30-33:
$result = dbquery("SELECT review, reviewid, item, type, r.chapid, c.uid, r.uid FROM ".$tableprefix."fanfiction_reviews AS r LEFT JOIN ".$tableprefix."fanfiction_chapters AS c ON c.chapid = r.chapid WHERE reviewid = '".$_POST['rid']."' LIMIT 1");
list($review, $reviewid, $item, $type, $chapid, $authid, $uid) = dbrow($result);
if($adminloggedin || $authid == $useruid) {
The simple solution is to just take that if statement out. Remove line 32 and line 44.
Review response will work in 3.3. π
Whoever said nothing is impossible never tried slamming a revolving door.
url: https://www.potionsandsnitches.org/fanfiction
php: 7.4.33 msql: 5.6.51-community GPL
efic version: 3.5.5 latest patches: yes
bridges: none mods: challenges, tracker, story end, beta, word
Do we have a projected date for 3.3 ?....
Thanks
TPTB
Nope, sorry. π Still working the bugs out.
Whoever said nothing is impossible never tried slamming a revolving door.
url: https://www.potionsandsnitches.org/fanfiction
php: 7.4.33 msql: 5.6.51-community GPL
efic version: 3.5.5 latest patches: yes
bridges: none mods: challenges, tracker, story end, beta, word
I could never get my site reviews to work properly (uses latest version) so I used steve34's mod and it works great, the members love it.
https://efiction.org/forums/index.php?topic=4956.0
If you want to see what it looks like I have it set up on my test site (yes I know it says 1.1, but I promise that it's the lastest version, I just never changed the file name)
https://efiction.org/forums/index.php?topic=4956.0
http://www.blacksole.co.uk/e-fiction/e-fiction1.1/index.php
There are stories and reviews posted for this test member that your welcome to look at:
Brit4
password = crones
Update on this:
just installed 3.3 on my test site
http://www.pretendercentre.com/missingtest/index.php
and tried to respond to reviews if it is a co-author on both admin and member unless i am primary author and got this message
You are not authorized to access that function.
the single author stories seem to be fine
ETA: might start a new thread for this since it is sort of a separate issue.
why is nothing ever easy?
url: http://www.pretendercentre.com/missingpieces/
php: 5.2.5 msql: 5.0.45-community
efic version: 3.4.3 latest patches: yes
bridges: none mods: challenges, displayword, beta-search
Marking this as solved for 3.3
why is nothing ever easy?
url: http://www.pretendercentre.com/missingpieces/
php: 5.2.5 msql: 5.0.45-community
efic version: 3.4.3 latest patches: yes
bridges: none mods: challenges, displayword, beta-search