Hello,
the installer and upgrade scripts are not working correctly with custom language files. When I open up the installer, it tells me to type in database information, sitekey, language and so on. After submitting, the installer should display all messages in the previously chosen language. The URL says install.php?step=2&language=de (for example), but most of the messages are still english.
I opened install.php and found this in multiple places:
if(file_exists("../langauges/".$language."_admin.php")) include("../languages/".$langauge."_admin.php");
Seems to be misspelled (lanauge). I think it should be:
if(file_exists("../languages/".$language."_admin.php")) include("../languages/".$language."_admin.php");
And then this in multiple places too:
if(file_exists("languages/".$language.".php")) include("languages/en.php");
I changed it to:
if(file_exists("languages/".$language.".php")) include("languages/".$language.".php");
Now my installer displays the correct strings at step2, but then it goes on with english messages. You my download my german files to try this yourself, see signature.
Okay thanks for the info. I'll fix the misspellings and look into the rest. I take it this was only with the install and you didn't run into the same misspellings with any updates? I didn't find any anyway.
Yes, only the installer. The upgrade scripts coming with 3.0.2 don't have these code sections, they only include the english file and don't look for others. But the upgraders coming with privious versions had these codes and the same misspellings.
OK the misspellings have being fixed, but the installer still isn't working with custom language files. It displays custom messages only after writing the config.php, then it goes on with english messages. And there's still another bug I think:
if(file_exists("languages/".$language.".php")) include("languages/en.php");
Well it can't display a custom language until you select one. The update script for 2.0 will now display in the custom language all the way through. The 1.1 update and 3.0 install have to start off in English though as there's no language set at start.
I will have the other fixed in the next update.
And this bug is also still valid after upgrade to 3.3
Steffen
3.3.1, still valid.
And even for 3.4, the installer is still english. 🙁
I just run another test install and the language problem is partially fixed. The prompts are in english for config file writing and setup of settings table, then it goes on with the table data insertion (panels, links, messages) in the choosen language until the end. I'll mark this topic as solved for now.
Steffen
Can you please check and see if this is still an issue with 3.5? Thank you!
Whoever said nothing is impossible never tried slamming a revolving door.
url: https://www.potionsandsnitches.org/fanfiction
php: 7.4.33 msql: 5.6.51-community GPL
efic version: 3.5.5 latest patches: yes
bridges: none mods: challenges, tracker, story end, beta, word
my last status report is still valid for 3.5. The installer becomes multi-lingual after setting up the config file and settings table, but not from the beginning of installation process. Half-solved bug. 🙂
I don't think that we are going to fix the first half, it's not really a bug.
Whoever said nothing is impossible never tried slamming a revolving door.
url: https://www.potionsandsnitches.org/fanfiction
php: 7.4.33 msql: 5.6.51-community GPL
efic version: 3.5.5 latest patches: yes
bridges: none mods: challenges, tracker, story end, beta, word
